Add tests, schema sync safeguards, and query/handler improvements
- Add bun test suite: SQL generator and value unit tests, plus MariaDB integration tests gated on BUN_MARIADB_TEST_DB - schema: add --dry-run and require confirmation (or --yes) before dropping tables/columns; block unapproved destructive statements - Always AND targetId with the query, regardless of searchOperator - Initialize lazily on first call; init throws instead of exiting - Generate IN (?, ?, ...) lists for IN / NOT IN - Share value binding between insert and update (booleans, embeddings, function values, "" -> NULL for non-text columns) - Keep Buffers and convert BigInt/Date without a JSON round-trip - DbSQL: report success for empty SELECT results - Run update() in a transaction with row locking - Key the client cache on the full connection config - Consolidate identifier quoting, drop dead code, merge column lookup - Read CLI version from package.json, pin @types/bun, chmod CLI on compile - Rebuild dist Co-Authored-By: Claude Opus 5.5 <[email protected]>
This commit is contained in:
Vendored
+48
@@ -1,5 +1,53 @@
|
||||
import dbHandler from "../db-handler";
|
||||
let schemaRunState = null;
|
||||
/**
|
||||
* Statements that discard stored data (tables or column values).
|
||||
*/
|
||||
export function isDestructiveSchemaStatement(query) {
|
||||
return /^\s*DROP\s+TABLE\b/i.test(query) || /\bDROP\s+COLUMN\b/i.test(query);
|
||||
}
|
||||
/**
|
||||
* Run `fn` with schema statements recorded but not executed.
|
||||
* Reads (information_schema) still run, so the plan is a close approximation:
|
||||
* steps that depend on earlier changes (e.g. after a table rename) may differ.
|
||||
*/
|
||||
export async function planSchemaQueries(fn) {
|
||||
const previous = schemaRunState;
|
||||
schemaRunState = { dryRun: true, statements: [], allowDestructive: true };
|
||||
try {
|
||||
await fn();
|
||||
return schemaRunState.statements;
|
||||
}
|
||||
finally {
|
||||
schemaRunState = previous;
|
||||
}
|
||||
}
|
||||
/**
|
||||
* Run `fn`, refusing any destructive statement that was not approved.
|
||||
*/
|
||||
export async function runSchemaQueriesGuarded(fn, allowDestructive) {
|
||||
const previous = schemaRunState;
|
||||
schemaRunState = { dryRun: false, statements: [], allowDestructive };
|
||||
try {
|
||||
await fn();
|
||||
}
|
||||
finally {
|
||||
schemaRunState = previous;
|
||||
}
|
||||
}
|
||||
export default async function runSchemaQuery({ query, values, config, }) {
|
||||
if (schemaRunState) {
|
||||
schemaRunState.statements.push(query);
|
||||
if (schemaRunState.dryRun) {
|
||||
return;
|
||||
}
|
||||
const allowed = schemaRunState.allowDestructive;
|
||||
if (allowed !== true &&
|
||||
isDestructiveSchemaStatement(query) &&
|
||||
!allowed.has(query)) {
|
||||
throw new Error(`Refusing unapproved destructive statement: ${query}. Re-run with --dry-run to review, or --yes to allow it.`);
|
||||
}
|
||||
}
|
||||
const res = await dbHandler({
|
||||
query,
|
||||
values,
|
||||
|
||||
Reference in New Issue
Block a user