Error handling bugfix: pass #1

dist/commands/start/index.js

@@ -1,7 +1,9 @@
 import { Command } from "commander";
 import path from "path";
 import writeErrorFile from "../../functions/write-error-file";
-import { existsSync } from "fs";
+import grabDirNames from "../../utils/grab-dir-names";
+import { existsSync, rmSync } from "fs";
+const { BUNX_BUNDLER_ERROR_EXIT_FILE } = grabDirNames();
 let retries = 0;
 let timeout;
 const MAX_RETRIES = 5;
@@ -9,6 +11,9 @@ export default function () {
     return new Command("start")
         .description("Start production server")
         .action(async () => {
+        // A stale error file from a previous session makes the bundler
+        // run in "silent" mode and pages fail with misleading messages.
+        rmSync(BUNX_BUNDLER_ERROR_EXIT_FILE, { force: true });
         await start();
     });
 }
@@ -47,7 +52,9 @@ async function start() {
         return await start();
     }
     const exited = await dev_process.exited;
-    if (exited) {
+    // Restart on any numeric exit (0 included). A null exit means the child
+    // was killed by a signal, which we must not restart.
+    if (exited != null) {
         retries++;
         timeout = setTimeout(() => {
             retries = 0;

dist/commands/start/prod-spawn.js

@@ -1,6 +1,27 @@
 import bunextInit from "../../functions/bunext-init";
 import startServer from "../../functions/server/start-server";
 import { log } from "../../utils/log";
+import writeErrorFile from "../../functions/write-error-file";
+// Same crash contract as the dev child: log the real error, record it in the
+// error file, and exit non-zero so the supervisor can restart and so the
+// bundler pipeline sees the failure.
+process.on("uncaughtException", (error) => {
+    log.error(`Uncaught exception: ${error}`);
+    writeErrorFile({ error, exitCode: 1, force: true });
+    process.exit(1);
+});
+process.on("unhandledRejection", (reason) => {
+    log.error(`Unhandled rejection: ${reason}`);
+    writeErrorFile({ error: reason, exitCode: 1, force: true });
+    process.exit(1);
+});
 log.info("Starting production server ...");
-await bunextInit();
-await startServer();
+try {
+    await bunextInit();
+    await startServer();
+}
+catch (error) {
+    log.error(`Failed to start production server: ${error}`);
+    writeErrorFile({ error, exitCode: 1, force: true });
+    process.exit(1);
+}