Error handling bugfix: pass #1

src/functions/bundler/plugins/esbuild-ctx-artifact-tracker.ts

@@ -6,6 +6,10 @@ import buildOnstartErrorHandler from "../build-on-start-error-handler";
 import _ from "lodash";
 import pagesSSRBundler from "../pages-ssr-bundler";
 import grabDirNames from "../../../utils/grab-dir-names";
+import {
+    logBuildErrorsOnce,
+    resetBuildErrorLog,
+} from "../../../utils/build-error-log";
 import { cpSync, existsSync, mkdirSync, rmSync, writeFileSync } from "fs";
 import fullRebuild from "../../server/full-rebuild";
 import path from "path";
@@ -55,15 +59,15 @@ export default function esbuildCTXArtifactTracker({
 
             build.onEnd(async (result) => {
                 if (result.errors.length > 0) {
+                    global.BUNEXT_BUILD_FAILED = true;
                     global.BUNEXT_RECOMPILING = false;
                     global.BUNEXT_IS_SERVER_COMPONENT = false;
 
-                    log.error(`Build errors:`);
-                    for (const err of result.errors) {
-                        log.error(
-                            `  ${err.text}${err.location ? ` (${err.location.file}:${err.location.line}:${err.location.column})` : ""}`,
-                        );
-                    }
+                    // Rebuild attempts repeat for every file edit / request
+                    // while the error persists; only log the error once.
+                    logBuildErrorsOnce(result.errors, (line) =>
+                        log.error(`  ${line}`),
+                    );
 
                     for (
                         let i = global.BUNEXT_HMR_CONTROLLERS.length - 1;
@@ -114,6 +118,17 @@ export default function esbuildCTXArtifactTracker({
                 const elapsed = (performance.now() - build_start).toFixed(0);
                 log.success(`[Built] in ${elapsed}ms`);
 
+                // A successful build clears the "last error" so a NEW incident
+                // with the same signature is reported again.
+                resetBuildErrorLog();
+
+                if (result.warnings.length > 0) {
+                    logBuildErrorsOnce(result.warnings, (line) =>
+                        log.warn(line),
+                    );
+                }
+
+                global.BUNEXT_BUILD_FAILED = false;
                 global.BUNEXT_MAIN_CTX_BUILD_STARTS = 0;
                 global.BUNEXT_BUNDLER_CTX_DISPOSED = false;