Moduletrace/cobble
2
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases 12 Wiki Activity

Say what a skill proposal changes, so a kept runbook never reads as saved

Browse Source 
propose_skill took no strict schema, so a runbook sent under another key
was dropped and the saved one proposed again; the confirm still said
"Saved". Now an unknown key is an error, a change that changes nothing is
refused, and both the bot and the confirm outcome are told which fields
change and whether the runbook is among them.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
This commit is contained in:
tben
2026-10-25 15:29:55 +01:00
co-authored by Claude Opus 5.5
parent b9c5311fde
commit 027c67c0a8
6 changed files with 152 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/functions/backend/db/extension-proposals/confirm-extension-proposal.ts
+18 -3
View File
@@ -10,6 +10,7 @@ import grabSkill from "../extensions/grab-skill";
import saveSkill from "../extensions/save-skill";
import syncMcpServer from "../extensions/sync-mcp-server";
import extensionEnvUses from "@/src/utils/extension-env-uses";
import skillProposalChanges from "@/src/utils/skill-proposal-changes";
import checkProposalData from "./check-proposal-data";
import claimExtensionProposal from "./claim-extension-proposal";
import grabExtensionProposal from "./grab-extension-proposal";
@@ -35,15 +36,16 @@ export default async function confirmExtensionProposal({ user_id, proposal_id }:
try {
if (proposal.kind == "skill") {
if (proposal.extension_id) await grabSkill({ skill_id: proposal.extension_id });
const current = proposal.extension_id ? await grabSkill({ skill_id: proposal.extension_id }) : null;
const changes = skillProposalChanges({ data: proposal.data, current });
const result_id = await saveSkill({
user_id,
data: { ...proposal.data, skill_id: proposal.extension_id || undefined },
});
const outcome = `Saved as skill #${result_id} (slug ${proposal.data.slug}).${
!proposal.extension_id && !proposal.data.all_bots ? " No bot gets it yet." : ""
}`;
current ? describeSavedChanges({ fields: changes.fields }) : ""
}${!proposal.extension_id && !proposal.data.all_bots ? " No bot gets it yet." : ""}`;
await BunSQLite.sql({
sql: `UPDATE extension_proposals SET outcome = ?, result_id = ?, updated_at = ? WHERE id = ?`,
@@ -120,3 +122,16 @@ export default async function confirmExtensionProposal({ user_id, proposal_id }:
return proposal;
}
/**
* What a confirmed change to a skill changed, so a runbook that stayed the
* same never reads as saved.
*/
function describeSavedChanges({ fields }: { fields: string[] }) {
if (!fields.length) return " Nothing changed: it was already saved like this.";
const named = fields.length == 1 ? fields[0] : `${fields.slice(0, -1).join(", ")} and ${fields[fields.length - 1]}`;
const runbook = fields.includes("runbook") ? "" : " The runbook is unchanged.";
return ` Changed: ${named}.${runbook}`;
}