Open the bot last visited, else the coordinator

`/admin/bots` sent the super admin to the coordinator and everyone else to their latest bot, which lost the thread each time the tab was reopened. The conversation pages now record where the browser is in two HttpOnly cookies (`cobble_last_visited_bot_id`, `..._workspace_id`, a year, `Secure` only over HTTPS), and the landing page opens that conversation again, in its workspace when it was one. A stale cookie can't loop: `grabReachableConversation` re-checks it with `grabUserConversation`, the gate the conversation pages use, so a revoked grant, a deleted bot or an archived workspace falls back to the coordinator (super admin) or the latest bot, first workspace, empty page. Signing out clears both cookies so the next user on that browser doesn't land in the previous one's conversation.
2026-10-22 11:18:19 +01:00
parent a8d8b680ad
commit 16f1e7904a
14 changed files with 402 additions and 10 deletions
@@ -0,0 +1,79 @@
+import { describe, expect, test } from "bun:test";
+import { AppData } from "@/src/data/app-data";
+import lastVisitedBotCookies from "./last-visited-bot-cookies";
+import { setCookies } from "./cookies";
+import readLastVisitedBot from "./read-last-visited-bot";
+
+const bot_cookie = AppData["LastVisitedBotCookieName"];
+const workspace_cookie = AppData["LastVisitedWorkspaceCookieName"];
+
+function requestWithCookies(): Request {
+    const res = new Response();
+    setCookies(
+        res,
+        lastVisitedBotCookies({ bot_id: 4, workspace_id: 9, secure: false }),
+    );
+    const cookie_header = res.headers
+        .getSetCookie()
+        .map((header) => header.split(";")[0])
+        .join("; ");
+
+    return new Request("http://localhost/admin/bots", {
+        headers: { Cookie: cookie_header },
+    });
+}
+
+describe("last visited bot cookies", () => {
+    test("round-trip a workspace conversation", () => {
+        expect(readLastVisitedBot({ req: requestWithCookies() })).toEqual({
+            bot_id: 4,
+            workspace_id: 9,
+        });
+    });
+
+    test("a bot's own chat leaves the workspace cookie empty", () => {
+        const res = new Response();
+        setCookies(res, lastVisitedBotCookies({ bot_id: 4, secure: false }));
+        const cookie_header = res.headers
+            .getSetCookie()
+            .map((header) => header.split(";")[0])
+            .join("; ");
+
+        const req = new Request("http://localhost", {
+            headers: { Cookie: cookie_header },
+        });
+
+        expect(readLastVisitedBot({ req })).toEqual({ bot_id: 4, workspace_id: null });
+    });
+
+    test("no cookies at all", () => {
+        expect(readLastVisitedBot({ req: new Request("http://localhost") })).toBeNull();
+    });
+
+    test("only the workspace cookie names no conversation", () => {
+        const req = new Request("http://localhost", {
+            headers: { Cookie: `${workspace_cookie}=9` },
+        });
+        expect(readLastVisitedBot({ req })).toBeNull();
+    });
+
+    test("a tampered bot id is ignored", () => {
+        const req = new Request("http://localhost", {
+            headers: { Cookie: `${bot_cookie}=1%20OR%201=1` },
+        });
+        expect(readLastVisitedBot({ req })).toBeNull();
+    });
+
+    test("they are HttpOnly, long-lived and not Secure on plain HTTP", () => {
+        const res = new Response();
+        setCookies(
+            res,
+            lastVisitedBotCookies({ bot_id: 4, secure: false }),
+        );
+        const [header] = res.headers.getSetCookie();
+
+        expect(header).toContain("HttpOnly");
+        expect(header).toContain(`Max-Age=${AppData["LastVisitedCookieMaxAgeSeconds"]}`);
+        expect(header).not.toContain("Secure");
+    });
+});