Let bots manage their hooks, with the user confirming what widens them

Bots get list_hooks, pause_hook and delete_hook, which act directly since they only take away. A new hook, or a new name, brief or filter, or switching a paused one back on, goes through propose_hook: it stores a hook_proposals row and puts a [hook-proposal:ID] card in the reply, which the user it was proposed to confirms or rejects. The card is read from what Confirm saves, with the bot's reason labelled as its own; confirming checks everything again and saves through the Hooks modal's helpers. A new hook's URL is shown on the card once, to the user only, never in the outcome the bot is told. What calls a hook, its computers and its signing are never proposed. Only chat replies propose, and a hook call's own run gets no hook tools, so a caller's payload can't reach them. Co-Authored-By: Claude Opus 5.5 <[email protected]>
2026-10-25 15:18:54 +01:00
parent 045167715d
commit 380d3ebb2f
54 changed files with 1983 additions and 55 deletions
@@ -0,0 +1,21 @@
+import type { HookProposalView } from "@/src/types";
+import hookProposalTitle from "./hook-proposal-title";
+
+type Params = {
+    view: HookProposalView;
+};
+
+/**
+ * What the chat tells the bot once the user decided on its hook proposal,
+ * so it carries on knowing what happened. Never the hook's URL: the
+ * outcome doesn't hold it.
+ */
+export default function hookProposalDecisionMessage({ view }: Params) {
+    const title = hookProposalTitle({ view });
+
+    if (view.status == "rejected") return `I rejected hook proposal #${view.id} (${title}). Nothing was saved.`;
+
+    if (view.status == "failed") return `I confirmed hook proposal #${view.id} (${title}), but it failed. ${view.outcome}`;
+
+    return `I confirmed hook proposal #${view.id} (${title}). ${view.outcome}`;
+}
@@ -0,0 +1,13 @@
+import type { HookProposalView } from "@/src/types";
+
+type Params = {
+    view: Pick<HookProposalView, "action" | "title">;
+};
+
+/**
+ * What a hook proposal does, e.g. `Add hook GitHub pushes` or `Change
+ * hook GitHub pushes`.
+ */
+export default function hookProposalTitle({ view }: Params) {
+    return `${view.action == "change" ? "Change" : "Add"} hook ${view.title}`;
+}