Let bots manage their hooks, with the user confirming what widens them

Bots get list_hooks, pause_hook and delete_hook, which act directly since they only take away. A new hook, or a new name, brief or filter, or switching a paused one back on, goes through propose_hook: it stores a hook_proposals row and puts a [hook-proposal:ID] card in the reply, which the user it was proposed to confirms or rejects. The card is read from what Confirm saves, with the bot's reason labelled as its own; confirming checks everything again and saves through the Hooks modal's helpers. A new hook's URL is shown on the card once, to the user only, never in the outcome the bot is told. What calls a hook, its computers and its signing are never proposed. Only chat replies propose, and a hook call's own run gets no hook tools, so a caller's payload can't reach them. Co-Authored-By: Claude Opus 5.5 <[email protected]>
2026-10-25 15:18:54 +01:00
parent 045167715d
commit 380d3ebb2f
54 changed files with 1983 additions and 55 deletions
@@ -0,0 +1,47 @@
+import { describe, expect, test } from "bun:test";
+import describeHookProposalDetails from "./describe-hook-proposal-details";
+
+describe("describeHookProposalDetails", () => {
+    test("a new URL hook shows who calls it, where it runs and its whole brief", () => {
+        const details = describeHookProposalDetails({
+            action: "create",
+            data: { title: "GitHub pushes", instructions: "Summarise each push.", source: "url", computer_id: 3 },
+            workspace_name: "Launch",
+            computers: new Map([[3, "Main"]]),
+        });
+
+        expect(details).toEqual([
+            { label: "Name", value: "GitHub pushes" },
+            { label: "Called by", value: "Anyone with its URL (shown to you once, when you confirm)" },
+            { label: "Runs in", value: "The workspace Launch" },
+            { label: "Runs on", value: "Main (#3)" },
+            { label: "Brief", value: "Summarise each push.", block: true },
+        ]);
+    });
+
+    test("a notification hook runs on the computer it watches unless told otherwise", () => {
+        const details = describeHookProposalDetails({
+            action: "create",
+            data: { title: "Slack", instructions: "Answer.", source: "browser_notifications", watch_computer_id: 2 },
+            computers: new Map([[2, "Desk"]]),
+        });
+
+        expect(details.find((d) => d.label == "Called by")?.value).toBe("Browser notifications on Desk (#2)");
+        expect(details.find((d) => d.label == "Takes")?.value).toBe("Every notification");
+        expect(details.find((d) => d.label == "Runs in")?.value).toBe("The bot's own chat with you");
+        expect(details.find((d) => d.label == "Runs on")?.value).toBe("Desk (#2)");
+    });
+
+    test("a change shows each field as it is and as it would be, and nothing else", () => {
+        const details = describeHookProposalDetails({
+            action: "change",
+            data: { instructions: "New brief.", enabled: true },
+            current: { id: 7, title: "GitHub pushes", instructions: "Old brief.", enabled: 0 },
+            computers: new Map(),
+        });
+
+        expect(details.map((d) => d.label)).toEqual(["Hook", "Brief now", "New brief", "Switch on"]);
+        expect(details[1]?.value).toBe("Old brief.");
+        expect(details[2]?.value).toBe("New brief.");
+    });
+});