Give workspace computers to attached bots in their own chat

A computer linked to a workspace now shows in the composer (and is usable
by tasks and replies) when chatting with any bot attached to that
workspace, not only in the workspace conversation. Members see those
computers through their assigned workers too, and assign_computer still
describes direct grants only.

src/utils/crew-access/computers-sql.ts

@@ -3,7 +3,8 @@ import type { CrewAccessParams, SqlCondition } from "./types";
 /**
  * The computers a user opens and sees: super admins and admins every one,
  * anyone else only those of the bots they chat with (the computers of
- * their workspaces, and those their assigned workers were given).
+ * their workspaces, those their assigned workers were given, and those of
+ * the workspaces their assigned workers are attached to).
  */
 export default function computersSql({ role, user_id, alias = "c" }: CrewAccessParams): SqlCondition {
     if (role != "member") return { sql: `1`, values: [] };
@@ -16,7 +17,13 @@ export default function computersSql({ role, user_id, alias = "c" }: CrewAccessP
             SELECT bc.computer_id FROM bot_computers bc
             JOIN bot_users bu ON bu.bot_id = bc.bot_id AND bu.user_id = ?
             JOIN bots b ON b.id = bc.bot_id AND b.kind != 'coordinator'
+            UNION
+            SELECT wc.computer_id FROM workspace_computers wc
+            JOIN workspaces w ON w.id = wc.workspace_id AND w.archived = 0
+            JOIN workspace_bots wb ON wb.workspace_id = w.id
+            JOIN bot_users bu ON bu.bot_id = wb.bot_id AND bu.user_id = ?
+            JOIN bots b ON b.id = wb.bot_id AND b.kind != 'coordinator'
         )`,
-        values: [Number(user_id), Number(user_id)],
+        values: [Number(user_id), Number(user_id), Number(user_id)],
     };
 }

src/utils/crew-access/crew-access-sql.test.ts

@@ -10,13 +10,13 @@ const db = new Database(":memory:");
 
 beforeAll(() => {
     db.run(`CREATE TABLE bots (id INTEGER PRIMARY KEY, kind TEXT)`);
-    db.run(`CREATE TABLE workspaces (id INTEGER PRIMARY KEY)`);
+    db.run(`CREATE TABLE workspaces (id INTEGER PRIMARY KEY, archived INTEGER DEFAULT 0)`);
     db.run(`CREATE TABLE bot_users (bot_id INTEGER, user_id INTEGER)`);
     db.run(`CREATE TABLE workspace_users (workspace_id INTEGER, user_id INTEGER)`);
     db.run(`CREATE TABLE workspace_bots (workspace_id INTEGER, bot_id INTEGER)`);
     db.run(`INSERT INTO bots VALUES (1, 'coordinator'), (2, 'worker'), (3, 'worker')`);
-    db.run(`INSERT INTO workspaces VALUES (10), (11)`);
-    db.run(`INSERT INTO bot_users VALUES (2, 7), (1, 7)`);
+    db.run(`INSERT INTO workspaces VALUES (10, 0), (11, 0)`);
+    db.run(`INSERT INTO bot_users VALUES (2, 7), (1, 7), (3, 9)`);
     db.run(`INSERT INTO workspace_users VALUES (11, 7)`);
     db.run(`INSERT INTO workspace_bots VALUES (11, 3)`);
     db.run(`CREATE TABLE computers (id INTEGER PRIMARY KEY)`);
@@ -46,6 +46,7 @@ describe("chatBotsSql", () => {
     test("a member only with workers assigned to them, even if the coordinator was", () => {
         expect(ids({ table: "bots", alias: "b", condition: chatBotsSql({ role: "member", user_id: 7 }) })).toEqual([2]);
         expect(ids({ table: "bots", alias: "b", condition: chatBotsSql({ role: "member", user_id: 8 }) })).toEqual([]);
+        expect(ids({ table: "bots", alias: "b", condition: chatBotsSql({ role: "member", user_id: 9 }) })).toEqual([3]);
     });
 });
 
@@ -72,4 +73,8 @@ describe("computersSql", () => {
         expect(ids({ table: "computers", alias: "c", condition: computersSql({ role: "member", user_id: 7 }) })).toEqual([21, 22]);
         expect(ids({ table: "computers", alias: "c", condition: computersSql({ role: "member", user_id: 8 }) })).toEqual([]);
     });
+
+    test("a member sees the computers of the workspaces their assigned workers are in", () => {
+        expect(ids({ table: "computers", alias: "c", condition: computersSql({ role: "member", user_id: 9 }) })).toEqual([21]);
+    });
 });