Let the coordinator manage skills, MCP servers and tools, behind a confirm card

- Coordinator tools in its own chat (super admin only): list_extensions, set_extension_access, delete_extension, and update_skill / update_mcp_server / update_custom_tool for what can't change where anything is sent (on/off, names, arguments, left-out tools) - Adding a skill, MCP server or tool, or changing a skill's words, a server's URL or headers or a tool's kind or config, goes through propose_skill / propose_mcp_server / propose_custom_tool: stored in extension_proposals with the bot's background check, shown as a [proposal:ID] chip that opens a card with Confirm and Reject - The card's facts are worked out by the app from what Confirm saves: the host, every {{env.KEY}} and whether it's saved, the config; for a skill its links, hosts, tool names, mentions of secrets and a diff against the saved runbook - Confirming decides once and checks again; a server or tool missing a key is saved switched off, and the outcome is posted to the bot in chat - Never from a bot: stdio servers, a URL whose host a template decides, envs in a prompt tool, a key's value Co-Authored-By: Claude Opus 5.5 <[email protected]>
2026-10-25 06:08:09 +01:00
parent e6c278198b
commit fefc295d15
77 changed files with 3307 additions and 12 deletions
@@ -0,0 +1,48 @@
+import type { SaveSkillRequest } from "@/src/schemas/extension-schema";
+import type { ExtensionProposalDetail, SkillRecord } from "@/src/types";
+import diffLines from "./diff-lines";
+import findSkillMentions from "./find-skill-mentions";
+
+type Params = {
+    data: SaveSkillRequest;
+    /**
+     * The skill as saved now, for a change: what's different is shown.
+     */
+    current: SkillRecord | null;
+};
+
+/**
+ * A proposed skill, line by line, read by the app from the runbook
+ * Confirm would save: what it points bots at (links, hosts, tool names,
+ * anything about secrets), for a change what's different from the saved
+ * one, then the whole runbook as plain text.
+ */
+export default function describeSkillProposal({ data, current }: Params): ExtensionProposalDetail[] {
+    const found = findSkillMentions({ text: [data.description, data.body].join("\n") });
+    const changed = ({ now, was }: { now: string; was?: string }) => (current && was != now ? `${now} (was: ${was || "empty"})` : now);
+
+    return [
+        { label: "Name", value: changed({ now: data.name, was: current?.name }) },
+        { label: "Slug", value: changed({ now: data.slug, was: current?.slug }) },
+        { label: "When it applies", value: changed({ now: data.description, was: current?.description }) },
+        { label: "Links in it", value: found.urls.join("\n") || "none", block: found.urls.length > 0 },
+        { label: "Hosts", value: found.hosts.join(", ") || "none" },
+        { label: "Tool names", value: found.tools.join(", ") || "none" },
+        { label: "About secrets", value: found.secrets.join(", ") || "nothing" },
+        ...(current
+            ? [
+                  {
+                      label: "Runbook changes",
+                      value: diffLines({ before: current.body, after: data.body }) || "None: the runbook is the same",
+                      block: current.body != data.body,
+                  },
+              ]
+            : []),
+        { label: "Runbook", value: data.body, block: true },
+        { label: "Starts", value: data.enabled ? "On" : "Off" },
+        {
+            label: "Who gets it",
+            value: data.all_bots ? "Every bot, now and new" : current ? "As it is now" : "No bot until it's given to some",
+        },
+    ];
+}