tbenandClaude Opus 5.5
380d3ebb2f
Bots get list_hooks, pause_hook and delete_hook, which act directly since they only take away. A new hook, or a new name, brief or filter, or switching a paused one back on, goes through propose_hook: it stores a hook_proposals row and puts a [hook-proposal:ID] card in the reply, which the user it was proposed to confirms or rejects. The card is read from what Confirm saves, with the bot's reason labelled as its own; confirming checks everything again and saves through the Hooks modal's helpers. A new hook's URL is shown on the card once, to the user only, never in the outcome the bot is told. What calls a hook, its computers and its signing are never proposed. Only chat replies propose, and a hook call's own run gets no hook tools, so a caller's payload can't reach them. Co-Authored-By: Claude Opus 5.5 <[email protected]>
53 lines
1.8 KiB
TypeScript
53 lines
1.8 KiB
TypeScript
import type { BotHookSource } from "@/src/dict/bot-hook-dict";
|
|
import AppError from "@/src/utils/app-error";
|
|
import grabBotComputers from "../computers/grab-bot-computers";
|
|
import grabUserComputer from "../computers/grab-user-computer";
|
|
|
|
type Params = {
|
|
user_id: number | string;
|
|
bot_id: number | string;
|
|
workspace_id?: number | string | null;
|
|
source: BotHookSource;
|
|
computer_id?: number | string | null;
|
|
watch_computer_id?: number | string | null;
|
|
};
|
|
|
|
/**
|
|
* Checks the computers a new hook would use: its runs' one must be one of
|
|
* the bot's there, and a browser-notification hook needs a computer to
|
|
* watch that both the bot and the user reach. Returns the computer its
|
|
* runs use (a notification hook's defaults to the watched one), or null
|
|
* for the bot's current one. Throws why when it can't.
|
|
*/
|
|
export default async function assertHookComputers({
|
|
user_id,
|
|
bot_id,
|
|
workspace_id,
|
|
source,
|
|
computer_id,
|
|
watch_computer_id,
|
|
}: Params) {
|
|
const watching = source == "browser_notifications";
|
|
const run_computer_id = computer_id || (watching ? watch_computer_id : null) || null;
|
|
|
|
if (watching && !watch_computer_id) {
|
|
throw new AppError(`Pick the computer whose notifications it gets.`);
|
|
}
|
|
|
|
if (run_computer_id || watch_computer_id) {
|
|
const computers = await grabBotComputers({ bot_id, workspace_id });
|
|
|
|
for (const id of [run_computer_id, watching ? watch_computer_id : null].filter(Boolean)) {
|
|
if (!computers.some((c) => String(c.id) == String(id))) {
|
|
throw new AppError(`This bot has no access to that computer.`);
|
|
}
|
|
}
|
|
}
|
|
|
|
if (watching && !(await grabUserComputer({ user_id, computer_id: watch_computer_id! }))?.id) {
|
|
throw new AppError(`You have no access to that computer.`);
|
|
}
|
|
|
|
return run_computer_id;
|
|
}
|